Closed richardellison closed 7 years ago
That's awesome Richard! For someone who said they wouldn't have much time, you've sure made a cracking start! I'll get straight back onto this tomorrow (including your PR). Thanks for the great work! I'll likely leave incorporation into an actual vignette on momentary pause awaiting CRAN appearance of osmdata
. Once that's done, street lines can be obtained from there in a flash, with just two lines of code.
@richardellison just a heads up for you: I hope to finish the package this week. Once I do, I would appreciate it is you could give it a half-decent look over to suggest any changes, improvements, whatever. I'll let you know when it's ready, and will be hoping you'll be able to devote some time later this week or early next week? We should then be able to move fairly rapidly on to an ropensci submit.
Sounds reasonable to me. I will try to get a chance to have a look at it once you're done although this coming week will be rather busy.
Richard
On 04/04/17 12:37, mark padgham wrote:
@richardellison https://github.com/richardellison just a heads up for you: I hope to finish the package this week. Once I do, I would appreciate it is you could give it a half-decent look over to suggest any changes, improvements, whatever. I'll let you know when it's ready, and will be hoping you'll be able to devote some time later this week or early next week? We should then be able to move fairly rapidly on to an ropensci submit.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mpadge/bikedata/issues/5#issuecomment-291461699, or mute the thread https://github.com/notifications/unsubscribe-auth/AKIixYdjcfAtTUkEFK8THTnVZldp27NBks5rsh1ZgaJpZM4MfNu3.
@richardellison heads-up part2: In terms of functionality, it's pretty much done now. Data can be loaded for all cities of which i am currently aware. Feel free to inspect and play and try to break it whenever you can find some time. The rest is just polishing, finishing vignette, extending tests, and #11 (I'm pretty sure #6 is also now sorted, but will confirm before closing).
And note that I've reverted to slightly slower C++ routines for London - search ''london'' in read_city_files.h
. The only city that bucks the otherwise consistent pattern of strict comma delimits.
Any suggestions, modifications, improvements much appreciated. Thanks in advance!
@richardellison with much gratitude for the above code: Vignette now has an equivalent version using osmdata
code that helps make it considerably more compact. It's a great finish to the vignette and to the package - thanks! A nicer html version will be online soon enough, or just run make
from the vignette
directory and it'll open up a version in your browser of choice.
Note also that i did eventually succumb to bundling sqlite3 which of course immediately alleviated many problems i was fighting against. Still feels a bit like cheating, but hey, makes life easier. Submission is now definitely officially imminent. CRAN first then ropensci as soon as that's online - i'll ping you in the latter submission
@richardellison vignette with graphic up via pkgdown here. Submitted to CRAN today; ropensci as soon as it's up.
Excellent, well done and sorry for not being more involved lately. Good to have the package on CRAN.
I think it may be worth adding a vignette with some examples of possible analysis that can be done with the data. Either making use of other packages or more standard examples (possibly using some spatial queries).
In that theme, as promised, below is the code used to generate this image. The sum_network_links function is in ropensci/stplanr#185. The create_index argument of the store_bikedata function is in #3.