ropensci / bold

Interface to the Bold Systems barcode webservice
https://docs.ropensci.org/bold
Other
17 stars 11 forks source link

updated description and generated codemeta file #48

Closed graceli8 closed 6 years ago

graceli8 commented 6 years ago

Added applicationCategory (DataAccess), ORCID identifier for author (Scott Chamberlain), and keywords (as advised by Scott) to DESCRIPTION file. Generated codemeta.json file from updated DESCRIPTION by running write_codemeta()

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files          11       11           
  Lines         296      296           
=======================================
  Hits          191      191           
  Misses        105      105

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1f4c0e...ed98c2d. Read the comment docs.

cboettig commented 6 years ago

@sckott This all looks good to me, will leave it to you to check over and merge.

@graceli8 nice work, and thanks for catching the issue with the GitHub url detection when running on a fork.

sckott commented 6 years ago

thanks @graceli8 !

just saw tweet https://twitter.com/AchimZeileis/status/917319708713668608

Add @ORCID_Org iDs to your #rstats pkg: person(... comment = c(ORCID = "")) in DESCRIPTION/Authors@R and CRAN will generate icon/link.

is that the way or the way @graceli8 has done it here?

cboettig commented 6 years ago

@sckott I think you're referring to that missing http, right? Yeah, that's probably necessary. Really nice to see CRAN has adopted this, I'm not sure the genesis of that change but wonder if Kurt was inspired by codemetar; we've been pushing that as a 'hack' way to add ORCID ids in CRAN, and it looks like they have now adopted it officially! very exciting. See https://github.com/codemeta/codemetar/pull/33/files

sckott commented 6 years ago

sorry, no, that in that tweet, the form he gave was comment = c(ORCID = "") vs here we have comment = ""

cboettig commented 6 years ago

@sckott ah, I didn't see that, I should have read more carefully. Yeah, his is obviously more general but I think either should work with codemetar, since in R it is just getting the value of the comment field.... lemme test...

cboettig commented 6 years ago

@sckott Yup, either way works for the codemeta.json generation.

@chrisfan24 @graceli8 For consistency with CRAN, can you adopt the named comment block for ORCID ids, as shown in Scott's example? This will make sure the ID badge shows up on the CRAN webpage as well as just in the codemeta.json files.

Thanks!

sckott commented 6 years ago

i imagine the codemeta.json file needs to be put in .Rbuildignore?

cboettig commented 6 years ago

@sckott Yup, good point. write_codemeta() should do that automatically but maybe it tripped up or wasn't committed?

@graceli8 can you add codemeta.json to .Rbuildignore?

sckott commented 6 years ago

great, thanks @graceli8 and @cboettig