ropensci / bold

Interface to the Bold Systems barcode webservice
https://docs.ropensci.org/bold
Other
17 stars 11 forks source link

Error in output of bold_seq() #79

Closed salix-d closed 2 years ago

salix-d commented 3 years ago

In the output of bold_seq(), $id and $gene were both the value of $id. There's a mistake in the indexes of split_fasta() on line 11 of zzz.R :

list(id = stuff[1], name = stuff[2], gene = stuff[1], sequence = seq)

should be :

list(id = stuff[1], name = stuff[2], gene = stuff[3], sequence = seq)

The accession from the fasta (which would be stuff[4] minus the sequence) also get lost.

sckott commented 2 years ago

thanks!

sckott commented 2 years ago

fixed via #80