search

ropensci / c14bazAAR

R Package - Download and Prepare C14 Dates from Different Source Databases
https://docs.ropensci.org/c14bazAAR
GNU General Public License v2.0
30 stars 12 forks source link

Lookup tables in the package #128

Closed nevrome closed 3 years ago

nevrome commented 3 years ago

I decided to move the lookup tables (db urls + version, thesauri) into the package as data objects. No more downloading from Github. With this change we do not need #122 and #125 any more.

This is a major interface change and we should increment the version number to 2.0.0, although many users will not feel any difference.

This PR also contains some minor changes to the getter and lookup functions as a consequence of the new data structure.

nevrome commented 3 years ago

@dirkseidensticker I implemented some major changes to simplify our work in the future. Maybe you could have a look.

nevrome commented 3 years ago

Thanks for taking a look, Dirk! Btw. what's the point of the :8ball: emoji? Is there a deeper meaning? :bread: :laughing: ?

dirkseidensticker commented 3 years ago

🎱 simply refers to pocketing the 8-ball in pool billiard, thus winning the game ;)