search

ropensci / chirps

API Client for CHIRPS
https://docs.ropensci.org/chirps/
Other
31 stars 12 forks source link

Tests fail #31

Open adamhsparks opened 3 years ago

adamhsparks commented 3 years ago

I was troubleshooting some of the tests when I found discrepancies in the precip indices.

This is from https://github.com/ropensci/chirps/blob/7f60a8e6f9ddcf89f79179af4f5911a446e4a2ff/tests/testthat/test-get_chirps.R#L13

> x
 [1]  0.00  0.00  0.00  0.00 20.18 38.35  0.00 38.35  0.00  0.00
> chirps$chirps
 [1]  9.26  0.00  0.00  0.00 18.51 38.35  0.00 38.35  0.00  0.00

I didn't go further as it's getting late here. Just flagging this to follow up later.

kauedesousa commented 3 years ago

Thanks @adamhsparks I am in the middle of other tasks but I will take a look asap

K

adamhsparks commented 3 years ago

No worries. I didn't mean to hurry you. Just flagging this so we're aware.

adamhsparks commented 3 years ago

I've done quite a bit of work on the tests in the devel branch. I've isolated some of the issues with vcr cassettes thanks to @maelle. I'm adding more tests for some of the uncovered functionality as well.