Correct vignette

[adamhsparks]

Vignette errors out upon knitting.

Don't know how to automatically pick scale for object of type function. Defaulting to continuous.
Quitting from lines 88-105 (Overview.Rmd) 
Error: Aesthetics must be valid data columns. Problematic aesthetic(s): x = date. 
Did you mistype the name of a data column or forget to add stat()?

Execution halted

[adamhsparks]

There is no date value to use on the x-axis.

[adamhsparks]

The "bin" col == "date"?

[adamhsparks]

I think this is fixed, @kauedesousa, please check https://github.com/agrobioinfoservices/chirps/commit/76813a1ee15d715e2d6cb99ba11b17a2001e2290 for me.

[kauedesousa]

I am not sure why this happens, but it was after https://github.com/agrobioinfoservices/chirps/commit/143d7cddab5f3760d233027667ab874a223549c6

Before that I had changed the function precip_indices to return the first day of each 'bin' in the time series, instead of the 'bin' number. Which I found meaningless when I made the plots for the vignette.

https://github.com/agrobioinfoservices/chirps/blob/2474573da2f0953bf2270636b86aa4b313358e4d/R/precip_indices.R#L87

But after the merge in https://github.com/agrobioinfoservices/chirps/commit/143d7cddab5f3760d233027667ab874a223549c6 it returned to its previous version, yielding this error in the vignette.

I fixed that here https://github.com/agrobioinfoservices/chirps/commit/812ebcc82f5bde4ad3006a53fb91d8bd97bfc6b2, but didn't managed to put the new plots in this new vignette template.

[kauedesousa]

I am still getting problems to deploy the plots in the vignette. Maybe you can give a try @adamhsparks ?

[adamhsparks]

yeah. tomorrow I'll have a look

-- Dr Adam H. Sparks Associate Professor of Field Crops Pathology  |  Centre for Crop Health Institute for Life Sciences and the Environment (ILSE)  |  Research and Innovation Division University of Southern Queensland | Toowoomba, Queensland | 4350 | Australia

Phone: +61746311948 Mobile: +61415489422 Mobile: +61415489422 On 3 Jan 2020, 21:48 +1000, Kauê de Sousa notifications@github.com, wrote:

I am still getting problems to deploy the plots in the vignette. Maybe you can give a try @adamhsparks ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[adamhsparks]

Did you fix this? I didn't have any issues knitting using the precompile.R script.

[kauedesousa]

precompile.R is working fine. But I don't get why the plots are not exported in the html files.

[adamhsparks]

ah! OK. I'll check that

[adamhsparks]

I think it's OK. Your version of pkgdown is out of date and Pandoc is older than mine is, maybe that's the issue?

I've just pushed a new version of the website with the images in the vignette article.

[kauedesousa]

Great! I just updated my Pandoc version to build the paper.

[adamhsparks]

be sure to update pkgdown as well, I suspect that's where the problem is

[adamhsparks]

I think we can close this now?

[kauedesousa]

I am still getting this problem. But since it comes from my PC settings, and I am changing my PC in the next days, I will close that

[adamhsparks]

We don't have to close it. I should check it on my Linux lablet as well I suppose.

However, once it's accepted for rOpenSci, the build process is automated for the docs.ropensci.org url.

On Mon, 6 Jan 2020 at 16:39, Kauê de Sousa notifications@github.com wrote:

Closed #9 https://github.com/agrobioinfoservices/chirps/issues/9.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/agrobioinfoservices/chirps/issues/9?email_source=notifications&email_token=AAYMIAVMN5PYW5FBJJZL7MTQ4LG3XA5CNFSM4KCHYSB2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVY6RLAA#event-2923238784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYMIARG6YERX2DVVECG5RDQ4LG3XANCNFSM4KCHYSBQ .

-- Dr Adam H. Sparks http://adamhsparks.netlify.com/ Associate Professor of Field Crops Pathology | Centre for Crop Health | Office C313

Phone (+61) 07 46311948 | Mobile 0415 489 422 | Twitter @adamhsparks https://twitter.com/adamhsparks

Institute for Life Sciences and the Environment | Research and Innovation Division University of Southern Queensland | Toowoomba, Queensland | 4350 | Australia

[kauedesousa]

OK. Let's keep it open. I also want to try my new pc.

[adamhsparks]

I've finally checked this on my Linux tablet. Everything builds fine in the vignette for me using that machine.