search

ropensci / coder

Classification of Cases into Deterministic Categories
https://docs.ropensci.org/coder/
22 stars 4 forks source link

remove dates_within() and filter_dates() #119

Closed eribul closed 4 years ago

eribul commented 4 years ago

I recommend removing (or at least making internal) dates_within() and filter_dates(). Their purpose (applying a filter on dates with some defaults) has no relationship to the rest of the package, and is something the user can do themselves with tools they're accustomed to (base R, data.table, or dplyr).

eribul commented 4 years ago

Review: I agree and have removed those functions. They were previously included since I was unaware of data.table::IDate and that data.table::between is optimized for date comparisons. The problem with normal date comparisons is that this can be realy slow for big data.