search

ropensci / coder

Classification of Cases into Deterministic Categories
https://docs.ropensci.org/coder/
22 stars 4 forks source link

Potential problem with name collisions #75

Closed eribul closed 4 years ago

eribul commented 4 years ago

Hypothesis: what if codedata have column with the same name as the date column from date. If thoose data.tables are mergered, those columns might be renamed for example P_SurgDate.x and P_SurgDate.y etc. This might be unfourtunate since it might hinder correct code mathing etc.

eribul commented 4 years ago

as.codedata should be stricter also if id column has a different name (should be identified). We should allow extra columns for conditions however so we can not simply ignore columns with names as above. This must be handled in codify (I guess?)

eribul commented 4 years ago

Hypothesis: what if codedata have column with the same name as the date column from date. If thoose data.tables are mergered, those columns might be renamed for example P_SurgDate.x and P_SurgDate.y etc. This might be unfourtunate since it might hinder correct code mathing etc.

Doesn't seem to be a problem!