search

ropensci / cyphr

:shipit: Humane encryption
https://docs.ropensci.org/cyphr
Other
93 stars 10 forks source link

gh-23: Look recursively for the root directory #34

Closed richfitz closed 4 years ago

richfitz commented 4 years ago

As it was, cyphr did not work from subdirectories without manually fully specifying the path down (e.g., cyphr::data_key("../../")) which does not work in orderly well as there are at least two possibilities there.

This PR adds a recursive search. It's a bit janky but the interface is at least ok and we can tidy up the implementation later (orderly uses a root/locate pair, which is slightly better but not perfect - we probably should pick up a dependency on rprojroot but I'd rather not at this point)

codecov-io commented 4 years ago

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         567    575    +8     
=====================================
+ Hits          567    575    +8
Impacted Files Coverage Δ
R/util.R 100% <100%> (ø) :arrow_up:
R/data.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03b35f9...f36f693. Read the comment docs.