ropensci / cyphr

:shipit: Humane encryption

https://docs.ropensci.org/cyphr

Other

93 stars 10 forks source link

Proposed figures for vignette (issue #12) #43

Closed superjai closed 3 years ago

superjai commented 3 years ago

Hello! Jai Ranganathan here. I am an ecologist and a big fan of rOpenSci. I thought I would try to help out and I heard from Stefanie Butland that the lack of figures in the vignettes for this package was a longstanding issue (issue #12 ) . I thought I would pitch in. This is my first time contributing to a github repo for which I didn't have write access, so I apologize in advance for any errors that I have made.

I created two figures for the vignette cyphr.Rmd, using the fantastic imagery in the github package pointblank as an inspiration. I will be the first to say that I am not a graphic designer, so please do let me know how they could be improved. If this seems to be roughly the right track, I will go ahead and create figures for the other vignette.

Thanks! Jai

Fixes #12

stefaniebutland commented 3 years ago

Thank you @superjai!

superjai commented 3 years ago

Hi @richfitz! I am glad that you find these figures to be useful. Let me address your points:

Instead of altering the pattern between public and private keys (which I couldn't get to look right), I instead changed the shape of public keys. What do you think?
The svg files were added. I created the figures in Inkscape, with the svg files being the source images and the png files being an exported version. You should be able to view svg files in a browser, but for some reason the formatting of the svg files is a bit off (when viewed in Chrome). Additionally, I just invited you to the repo.
The DESCRIPTION file was changed.

codecov-io commented 3 years ago

Codecov Report

Merging #43 (dbb04d8) into master (b718ca5) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          680       680           
=========================================
  Hits           680       680

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b718ca5...dbb04d8. Read the comment docs.

superjai commented 3 years ago

Done!