ropensci / cyphr

:shipit: Humane encryption
https://docs.ropensci.org/cyphr
Other
93 stars 10 forks source link

Addition of figure to data.rmd vignette (issue #12) #45

Open superjai opened 3 years ago

superjai commented 3 years ago

Hi @richfitz - here is a figure for the other vignette. What do you think?

codecov-io commented 3 years ago

Codecov Report

Merging #45 (34bbd6e) into master (dbb04d8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          680       680           
=========================================
  Hits           680       680           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbb04d8...34bbd6e. Read the comment docs.

superjai commented 3 years ago

Hi @richfitz - I was just wondering if you had any thoughts on the figure I created for your vignette. Thanks!

richfitz commented 3 years ago

Hi @superjai - thanks for this and for the prompt. I have had, but need to get the time to review properly as I think they need some work. Unfortunately I've been snowed under recently so have not managed to get the time to do so but will look as soon as I can 🙏