Closed cboettig closed 4 years ago
Hey @cboettig , thanks. I think we also want to trickle that change over to
https://github.com/ropensci/datapack/blob/master/R/DataPackage.R#L902:L903 and https://github.com/ropensci/datapack/blob/master/R/DataPackage.R#L915:L916
so replaceMember
also uses SHA-256 by default.
Yeah, @amoeba, I think you are right.
Plus, we need to decide if we also want the checksum algorithm to be settable by the caller as described in #117 as the optional checksum = "SHA-256"
parameter. That would require a bit more conditional logic, and to make sure the listed algorithm is in the Library of Congress list, and map that to the algorithm name for the digest
function.
Additional changes mentioned will be made via additional commits to master branch
addresses #117. I think this is all that's needed?