Prepare 1.4.1 release

[gothub]

• [x] close any issues assigned to this release
• [x] check and update contributors list and update CITATION if needed
• [x] Update version number, publish date, etc. in DESCRIPTION
• [x] check that all new functions have unit tests
• [x] update NEWS
• [x] update cran_comments
• [x] run revdepcheck::revdep_check()
  • output from revdepcheck::revdep_check():

    > revdepcheck::revdep_check()
    ── INSTALL ────────────────────────────────────────────────────────────────────────────────────── 2 versions ──
    Installing CRAN version of datapack
    Installing DEV version of datapack
    ── CHECK ──────────────────────────────────────────────────────────────────────────────────────── 1 packages ──
    ✓ dataone 2.2.1                          ── E: 0     | W: 0     | N: 0                                         
    OK: 1                                                                                                        
    BROKEN: 0
    Total time: 11 min
    ── REPORT ─────────────────────────────────────────────────────────────────────────────────────────────────────
    Writing summary to 'revdep/README.md'
    Writing problems to 'revdep/problems.md'
    Writing failures to 'revdep/failures.md'
    Writing CRAN report to 'revdep/cran.md'

• [x] test with testthat 3e
• [x] rhub::check_for_cran()
  • [x] fedora-clang-devel (Fedora Linux, R-devel, clang, gfortran)
  • [x] fedora-gcc-devel (Fedora Linux, R-devel, GCC)
  • [x] macos-m1-bigsur-release (Apple Silicon (M1), macOS 11.6 Big Sur, R-release)
  • [x] macos-highsierra-release-cran (macOS 10.13.6 High Sierra, R-release, CRAN's setup)
  • [x] windows-x86_64-devel (Windows Server 2008 R2 SP1, R-devel, 32/64 bit)
  • [x] windows-x86_64-release (Windows Server 2008 R2 SP1, R-release, 32/64 bit)
• [x] devtools::check()
  • [x] macOS 11.5.2, R 4.2.0
  • [x] Ubuntu 17.10, R 4.1.3
• [x] via win-builder
  • [x] Windows: x86_64-w64-mingw32 (64-bit) R 4.1.3
  • [x] Windows: x86_64-w64-mingw32 (64-bit) R 4.1.0
  • [x] Windows: x86_64-w64-mingw32 (64-bit) R devel
• After release is posted by CRAN:
  • [ ] create release tag

[jeanetteclark]

only one issue, which crops up on Fedora:

Last 13 lines of output:
  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 312 ]

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error (test_DataPackage.R:414:2): BagIt serialization works ─────────────────
  Error in `zip(zipFile, files = list.files(recursive = TRUE), flags = "-q")`: argument 'zip' must be a non-empty character string
  Backtrace:
      ▆
   1. ├─datapack::serializeToBagIt(dp) at test_DataPackage.R:414:1
   2. └─datapack::serializeToBagIt(dp)
   3.   └─datapack .local(x, ...)
   4.     └─utils::zip(zipFile, files = list.files(recursive = TRUE), flags = "-q")

  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 312 ]
  Error: Test failures
  Execution halted

[jeanetteclark]

after merging in Tommy's PR, the above test now passes.

@mbjones I think this is ready for you or someone else to run through testing before submitting to CRAN

[mbjones]

@jeanetteclark I fixed a typo in NEWS and updated the README, and ran check(cran=TRUE) locally -- everything seems to be good to go. I didn't see the OS results for rhub() in the cran-comments, which we use to record which specific OS/R versions we tested against. Could you provide that, and then go ahead and release() when you are ready.

[jeanetteclark]

Okay I can add that @mbjones. I'm curious about this checklist, there is a long list of different testing mechanisms. Can we thin this out for future releases since many seem redundant? For this package, I think we just need the rhub matrix below. For dataone we'll need a separate set of tests you can run with auth

• fedora-clang-devel (Fedora Linux, R-devel, clang, gfortran)
• fedora-gcc-devel (Fedora Linux, R-devel, GCC)
• macos-m1-bigsur-release (Apple Silicon (M1), macOS 11.6 Big Sur, R-release)
• macos-highsierra-release-cran (macOS 10.13.6 High Sierra, R-release, CRAN's setup)
• windows-x86_64-devel (Windows Server 2008 R2 SP1, R-devel, 32/64 bit)
• windows-x86_64-release (Windows Server 2008 R2 SP1, R-release, 32/64 bit)

[mbjones]

The rhub checks are great but not sufficient for CRAN, which requires the winbuilder release and devel checks. In addition, we generally check on one or two local MacOS installs which we are using for development -- typically I do this before sending to rhub because rhub is so slow that we want to have eliminated any problems before we send it. So, I think all of that testing is needed for any package submission to CRAN. Looking over the checklist, I think everything there is needed for a CRAN release and/or things we should do for every release, so I think the list should stay the same.

[jeanetteclark]

okay sounds good. I was debugging issues that arose from the rhub checks yesterday. took forever