search

ropensci / datapack

An R package to handle data packages
https://docs.ropensci.org/datapack
44 stars 9 forks source link

Group permissions by subject #54

Closed amoeba closed 7 years ago

amoeba commented 8 years ago

Addresses https://github.com/ropensci/datapack/issues/53. I find unique subjects, adding an block for each, and for each subject, I find the unique set of their permissions and add blocks for each as sibling node to the respective element.

Edit: Spelling.

mbjones commented 8 years ago

This looks good. Is there a need for any extended tests to make sure that this new layout is working correctly?

amoeba commented 8 years ago

Added a pretty basic test.

mbjones commented 7 years ago

@gothub indicated in the 1.0.1 release notes that a similar feature of grouping subjects in access policies was included. Is this pull request #54 different than what was already released? If so, can this PR be closed, or should it instead be fixed up and merged? Thoughts, @amoeba ?

amoeba commented 7 years ago

Looks like this is already in and this PR can be closed without merge. See https://github.com/ropensci/datapack/blob/master/R/SystemMetadata.R#L350

gothub commented 7 years ago

@amoeba apologies Bryce, I didn't see your PR way back then - I've made checking for PRs part of my workflow since then.

amoeba commented 7 years ago

Np at all. It was a couple lines of code.