Closed amoeba closed 7 years ago
@amoeba The current development version of dataone
uploadDataPackage does create
resource maps with creator="DataONE R Client", but as you point out, there is no current
default. Since arcticdatautils
and potentially anyone else could create resource maps without
specifying a creator, should a default value be set in createFromTriples
? What would the value
be?
Yeah I think so. Since arcticdatautils only uses createFromTriples
, that would explain the missing Agent on those resource maps. My mistake! createFromTriples
seems to be the best place to put the default behavior.
Continuing to use "DataONE R Client" is reasonable. I guess it's either that, datapack
, or redland
. What do you think?
@amoeba Note that the creator
and modified time
fix is not on CRAN yet, and has only
been in github for about 3 weeks.
Sounds good, I'll update createFromTriples
to set the default of 'DataONE R Client`.
Sounds great, thanks @gothub
Fixed in commit 888d2a70bbb7d7f082e39424a429429bb6b989f4
Thanks!
I'm creating this ticket after a discussion on the arctic-data repo (on our NCEAS GHE) about resource maps showing up that were not compliant with the OAI-ORE spec for Resource Maps.
From the spec
A quick glance of the code makes it look like the
dc:modified
term is always added (good!) but theAgent
statement is only added if thecreator
argument is set whencreateFromTriples
is called. Because these are required, it would be good to exercise this a bit and, ideally, write a test or two to verify thecreateFromTriples
method always produces spec-complaint Resource Map RDF/XML.