search

ropensci / datapack

An R package to handle data packages
https://docs.ropensci.org/datapack
44 stars 9 forks source link

Remove DataObject 'suggestedFilename' argument #86

Closed gothub closed 7 years ago

gothub commented 7 years ago

The DataObject initialize() needs the location of the source data (filename) and the name (stored in sysmeta) of the file to download to. Both these items can be derived from the filename argument, so suggestedFilename can be removed. Input data can be specified via the dataobj parameter, in which case filename must still be specified, to only be used as sysmeta.fileName and not the data source.

Also ensure that filename works for both relative and absolute filenames.

gothub commented 7 years ago

Implemented in commit f78f6715811fbf0db9fcf3ae190fcf5c8620c8ec