search

ropensci / dev_guide

rOpenSci Packages: Development, Maintenance, and Peer Review
https://devguide.ropensci.org
Creative Commons Attribution Share Alike 4.0 International
159 stars 54 forks source link

second Review preface.pt.Rmd #789

Closed IldySilva closed 6 months ago

IldySilva commented 6 months ago

referencing @pedropark99 coment

pedropark99 commented 6 months ago

Hey @IldySilva ! First of all, thank you for your review! Now, this specific PR is trying to add your second review to the wrong place.

Instead of adding changes into ropensci:preface.Rmd-pt-auto, this PR should be adding changes in pedropark99:preface.Rmd-pt-review which is the branch that contains all changes during the review process.

I manually added your suggested changes to PR #785, just in case. But I do believe that the best approach here is for you remake this PR so that it points to pedropark99:preface.Rmd-pt-review. Because then, I can add your commit to PR #785 .

And I think that adding your commit to it is important, because then we have registered inside GitHub that you contributed to the project. In other words, we do not want to lose vision of all contributors to this project. That makes sense to you?

IldySilva commented 6 months ago

Excellent, @pedropark99 . understood. In that case, I'll close this pull request and pay attention to this detail in the next contributions