search

ropensci / dev_guide

rOpenSci Packages: Development, Maintenance, and Peer Review
https://devguide.ropensci.org
Creative Commons Attribution Share Alike 4.0 International
159 stars 54 forks source link

Editor dashboard for #828 #829

Closed mpadge closed 6 days ago

mpadge commented 6 days ago

@maelle I've updated all the URLs, but the build fails because of

[ 2/29] preface.Rmd

processing file: preface.Rmd
1/3                  
2/3 [unnamed-chunk-1]
Error in `air_api_key()`:
! AIRTABLE_API_KEY environment variable is empty. See ?airtabler for help.
Backtrace:
 1. reviewers$`reviewers-prod`$select_all(...)
 2. airtabler::air_select(...)
 9. airtabler:::air_api_key()

I don't understand why as that is both set here and exported to the workflow step here: https://github.com/ropensci/dev_guide/blob/12f4c8211f76700b2f56afff5ad62592b8b72f98/.github/workflows/pr.yml#L37-L41

Any ideas?

maelle commented 6 days ago

probably because it's an external PR, feel free to merge :-) (and we should get that workflow fixed, it should stop sooner)

mpadge commented 6 days ago

Okay, shall do, thanks. But for the sake of proper form here, can you please first approve? Then I'll merge