expose the format argument for progress bars

ropensci / drake

An R-focused pipeline toolkit for reproducibility and high-performance computing

https://docs.ropensci.org/drake

GNU General Public License v3.0

1.34k stars 129 forks source link

expose the format argument for progress bars #1296

Closed kendonB closed 4 years ago

kendonB commented 4 years ago

Prework

[x] Read and abide by drake's code of conduct.
[x] Search for duplicates among the existing issues, both open and closed.

Proposal

The format argument here: https://github.com/ropensci/drake/blob/e3ef6c9e8a3f28d14d1d76f0811b25eae682a0bf/R/logger.R#L6 has a lot of options in the progress package. Could these be exposed to the user via make?

wlandau commented 4 years ago

What sorts of custom progress bar formats do you plan to use?

wlandau commented 4 years ago

It's hard for me to see the value added for this feature. I guess eta might be nice, but it seems misleading when it comes to targets because they all take different amounts of time to complete, and I'm not sure I want users to get the wrong idea.