ropensci / elastic

R client for the Elasticsearch HTTP API
https://docs.ropensci.org/elastic
Other
245 stars 58 forks source link

Adding connection details for AWS hosted ES #158

Closed nelsonSchwarz closed 7 years ago

nelsonSchwarz commented 7 years ago

Easy access in README for people just starting to query ES.

codecov-io commented 7 years ago

Current coverage is 65.72% (diff: 100%)

Merging #158 into master will not change coverage

@@             master       #158   diff @@
==========================================
  Files            37         37          
  Lines          1234       1234          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            811        811          
  Misses          423        423          
  Partials          0          0          

Powered by Codecov. Last update 93f00f5...c0d0e5d

sckott commented 7 years ago

thanks @nelsonSchwarz !

I assume this is related to http://stackoverflow.com/questions/40895027/connecting-to-aws-elasticsearch-service-using-r-getting-404-error

Can you make the edits in the README.Rmd and README.md files please

nelsonSchwarz commented 7 years ago

Sure. I'll make the same changes to the .Rmd file

sckott commented 7 years ago

@nelsonSchwarz Hmm, looks like you've opened a new PR, I meant to add the change to README.md to this PR

sckott commented 7 years ago

you can just make new commits to the same branch

nelsonSchwarz commented 7 years ago

Oh... I'm sorry. I don't know how to do that. It's my first time requesting a pull...

nelsonSchwarz commented 7 years ago

Oh ok, should I close the previous PR and make the same commits here?

sckott commented 7 years ago

No problem at all. Yes, add the readme.rmd change to this PR,

sckott commented 7 years ago

if you're using the web interface, just change the file in your version at https://github.com/nelsonSchwarz/elastic/tree/patch-1

nelsonSchwarz commented 7 years ago

Now it should be correct.

sckott commented 7 years ago

thanks very much!