search

ropensci / elastic

R client for the Elasticsearch HTTP API
https://docs.ropensci.org/elastic
Other
245 stars 58 forks source link

Document id required in docs_create function #216

Closed jbrant closed 6 years ago

jbrant commented 6 years ago

It seems that the docs_create function requires a manually specified document ID. Why not make that an optional field and let Elasticsearch generate the ID?

sckott commented 6 years ago

thanks @jbrant - we have this already implemented in docs_bulk, but not here, i guess b/c nobody raise the issue yet.

anyway, change made, reinstall remotes::install_github("ropensci/elastic") and try it again.

jbrant commented 6 years ago

Awesome - thank you!