ropensci / elastic

R client for the Elasticsearch HTTP API
https://docs.ropensci.org/elastic
Other
245 stars 58 forks source link

Rectified error in example description. #235

Closed M-YD closed 5 years ago

M-YD commented 5 years ago

Rectified error in _id number; example shows _id == 4, description states _id == 1.

Description

Example description states that records where _id == 1 will be searched but example showed _id == 4. I changed the description to match the example as this was clearly a mistake in the description and not in the example.

codecov-io commented 5 years ago

Codecov Report

Merging #235 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #235   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          43     43           
  Lines        1502   1502           
=====================================
  Misses       1502   1502

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 178dee7...1259988. Read the comment docs.

sckott commented 5 years ago

thanks @MusTheDataGuy - Can you make the change in the README.Rmd as well?

M-YD commented 5 years ago

thanks @MusTheDataGuy - Can you make the change in the README.Rmd as well?

All done and pull request created.

sckott commented 5 years ago

thanks. Instead of opening a new pull request, can you add changes to this one? Let me know if you're not sure how to do that

sckott commented 5 years ago

to make changes to this pull request instead of opening a new one go to your fork and branch of this repo at https://github.com/MusTheDataGuy/elastic/tree/patch-1 - And edit the file or files there and it will automatically get added here!

M-YD commented 5 years ago

to make changes to this pull request instead of opening a new one go to your fork and branch of this repo at https://github.com/MusTheDataGuy/elastic/tree/patch-1 - And edit the file or files there and it will automatically get added here!

Great, thank you, @sckott - that makes perfect sense!

sckott commented 5 years ago

thanks very much @MusTheDataGuy