ropensci / elastic

R client for the Elasticsearch HTTP API
https://docs.ropensci.org/elastic
Other
245 stars 58 forks source link

errors rework for new setup #242

Closed sckott closed 5 years ago

sckott commented 5 years ago

https://github.com/ropensci/elastic/blob/r6-conn/R/Elasticsearch.R#L121 here we set the errors user preference as an env var, but this would then overwrite an error preference for another connection object. Make this justs a var in the object itself, and here https://github.com/ropensci/elastic/blob/r6-conn/R/httr-verbs.R#L151 use the conn object error var - will require that we pass conn object to geterror() calls

sckott commented 5 years ago

related to #87