move all egs to not using types

ropensci / elastic

R client for the Elasticsearch HTTP API

https://docs.ropensci.org/elastic

Other

245 stars 58 forks source link

move all egs to not using types #251

Closed sckott closed 4 years ago

sckott commented 5 years ago

see https://www.elastic.co/guide/en/elasticsearch/reference/7.0/removal-of-types.html

in v7 types are deprecated
in v8 types will be removed

Aeilert commented 5 years ago

Question: Does this include changing the behavior of :

if (is.null(type)) 
        type <- index

I think setting doc-type to the specified index name as a default option causes a lot of unwanted behavior in ES, especially with the upgrade to v7.

sckott commented 5 years ago

good question. i agree does make sense to get rid of that behavior of setting the type to index if type not given. opened an issue since it seems separate enough

Aeilert commented 5 years ago

Okey. Will open a separate issue.

Edit: I see you have already done this.

sckott commented 4 years ago

work on branch type-scrubbing