Make validate_units use the right eml-unitDictionary

ropensci / emld

:package: JSON-LD representation of EML

https://docs.ropensci.org/emld

Other

13 stars 6 forks source link

Make validate_units use the right eml-unitDictionary #60

Closed amoeba closed 4 years ago

amoeba commented 4 years ago

Fixes #56

While eml_validate determines the root schema to use when validating, validate_units was still defaulting to the version set in emld_db. This changes validate_units so it uses the appropriate eml-unitDictionary.xml file for the root element.

I've also added two test files and a test to exercise this so we know validate_units is working correctly now.

cboettig commented 4 years ago

are we about due for a CRAN release with this or anything additional / simple we should fix first?

amoeba commented 4 years ago

Looking at the open issues here, I think this'd be a good time to release.