cboettig
commented
4 years ago @amoeba thanks! Looks like the current dev version of emld will break two tests on EML: (both related to units by the look of it)
> library(testthat)
> library(EML)
>
> test_check("EML")
── 1. Failure: Reading default unit definitions (@test-units.R#47) ────────────────────────────────────────────────────────────────────────────────────────────────────────────────
dim(unitList$units) not equal to c(195, 8).
2/2 mismatches (average diff: 71)
[1] 335 - 195 == 140
[2] 10 - 8 == 2
── 2. Failure: Reading default unit definitions (@test-units.R#49) ────────────────────────────────────────────────────────────────────────────────────────────────────────────────
dim(unitList$unitTypes) not equal to c(288, 4).
1/2 mismatches
[1] 297 - 288 == 9
══ testthat results ═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
[ OK: 89 | SKIPPED: 5 | WARNINGS: 3 | FAILED: 2 ]
1. Failure: Reading default unit definitions (@test-units.R#47)
2. Failure: Reading default unit definitions (@test-units.R#49) Looks like these break for both the current CRAN version of EML and the GitHub dev version. Can you take a quick look? We should probably push a patch to EML first to avoid revdeps issues on the emld submission.
amoeba
0.5.0 includes some nice QOL fixes but also a pretty important update in #60 to make EML 2.2.0 docs validate using the correct unit list. I think @cboettig had asked if this was a good time for a release and I think so. I've rcmdcheck'd my way around and I think things are good for a release whenever you can sit down to do it, @cboettig. Please see my PR in #64 before releasing and then I think this is good to go.