Removing if statement in set_email function

ropensci / essurvey

Download data from the European Social Survey

https://docs.ropensci.org/essurvey

Other

49 stars 9 forks source link

Closed jlopezper closed 5 years ago

jlopezper commented 5 years ago

This PR fixes an issue in set_email() function by removing a unnecessary if statement that didn't allow to overwrite the email once set.

cimentadaj commented 5 years ago

Can you also add tests for set_email and add the changes in the NEWS file with a reference to to the PR? Thanks!

cimentadaj commented 5 years ago

It seems that the changes are breaking some of the tests in travis. Can you check that out? https://travis-ci.org/ropensci/essurvey

jlopezper commented 5 years ago

I think I won't be able to sort this problem out since there's an encrypted environment variable defined in the .travis.yml file.

According to this:

Encrypted environment variables are not available to pull requests from forks due to the security risk of exposing such information to unknown code.

cimentadaj commented 5 years ago

I've merged this to check whether it passes the test on the master branch. I'll also add you as a CTB to the DESCRIPTION.

cimentadaj commented 5 years ago

Thank you 👍

jlopezper commented 5 years ago

Great, thanks!