search

ropensci / europepmc

R Interface to Europe PMC RESTful Web Service
https://docs.ropensci.org/europepmc
27 stars 8 forks source link

set default batch_size to 1000 and limit to 25? #5

Closed cstubben closed 8 years ago

cstubben commented 8 years ago

Also, I think setting both the batch_size and limit is confusing in epmc_search. I can't think of a good reason to not get the maximum pageSize of 1000 ( instead of paging through 10 rest queries of 100 results each). In fact, I would drop batch_size as an option and just have a limit =25 for a default.

njahn82 commented 8 years ago

Thanks, the default limit is 25. Batch_size is by default 1000 and is dropped as function parameter. I will implement this behavior also for the other functions that need to loop over result pages.

cstubben commented 8 years ago

Works great, thanks!