ropensci / geojsonio

Convert many data formats to & from GeoJSON & TopoJSON

https://docs.ropensci.org/geojsonio

Other

150 stars 59 forks source link

Explicitly set stringsAsFactors = TRUE in tests. #166 #167

Closed ateucher closed 4 years ago

ateucher commented 4 years ago

This is a fix for #166, just by setting stringsAsFactors = TRUE in the test. We could also expose stringsAsFactors in topojson_read() (default FALSE), which might be friendly to users? It can currently be set in ... and sent through to to sf::st_read().

codecov-io commented 4 years ago

Codecov Report

Merging #167 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   57.81%   57.81%           
=======================================
  Files          30       30           
  Lines        1318     1318           
=======================================
  Hits          762      762           
  Misses        556      556

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbe3ea7...2d76922. Read the comment docs.

sckott commented 4 years ago

looks like you're still tweaking things, let me know when you're good to go

ateucher commented 4 years ago

@sckott finally all passing if you want to have a look. Pretty messy commits, so probably want to squash them!

sckott commented 4 years ago

Okay, thanks, having a look

sckott commented 4 years ago

thanks so much for sorting this out

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.