search

ropensci / geojsonio

Convert many data formats to & from GeoJSON & TopoJSON
https://docs.ropensci.org/geojsonio
Other
150 stars 59 forks source link

Testthat 3e update #188

Closed czeildi closed 2 years ago

czeildi commented 2 years ago

Update to testthat 3rd edition and replace deprecated functions.

Description

This PR updates test suite to testthat 3rd edition and replaces deprecated functions. In addition, a few informational messages during test run were silenced.

Not all 3rd edition best practices are followed yet (like text fixtures) but the test run is without warning.

I believe dealing with text fixtures (more idiomatic setup, teardown) would be easier to handle in a separate pull request. This is also why it might make sense to wait for this second pr before closing the #183 issue.

Related Issue

183

Example

mikemahoney218 commented 2 years ago

This is huge @czeildi , thank you so much! I just approved the CI runs, let's see how things look...

mikemahoney218 commented 2 years ago

Fantastic! Thank you so much, this is a huge help.

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.