search

ropensci / git2rdata

An R package for storing and retrieving data.frames in git repositories.
https://ropensci.github.io/git2rdata/
GNU General Public License v3.0
99 stars 13 forks source link

Update efficiency.Rmd #19

Closed hansvancalster closed 5 years ago

hansvancalster commented 5 years ago

Description

Fixed some typos. Impressive!

General remark: I took me some time to figure out the meaning of the figures in the section in git repositories. Probably the figure headings and legend can be improved.

Related Issue

NA

Example

NA

hansvancalster commented 5 years ago

For a reader who looks at this in a hurry, the confusing part is that the default method for write_vc is the optimal setting in terms of storage efficiency, whereas the write.table default is least efficient.

You could consider the following change to the legend: use as levels for method (optimized and not optimized) and explain the mapping in the figure heading. Thus:

- write_vc + default -> write_vc + optimized
- write_vc + verbose -> write_vc + not optimized
- write.table + default -> write.table + not optimized
- write.table + sorted -> write.table + optimized