ropensci / git2rdata

An R package for storing and retrieving data.frames in git repositories.

https://ropensci.github.io/git2rdata/

GNU General Public License v3.0

99 stars 12 forks source link

Fix link to broken logo + shorten title to package title #54

Closed peterdesmet closed 4 years ago

peterdesmet commented 4 years ago

Description

Use relative link for logo: should work on GitHub and pkgdown website
Use git2rdata as title
Fix typo in alt

Related Issue

Example

codecov-io commented 4 years ago

Codecov Report

Merging #54 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #54   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         696    696           
=====================================
  Hits          696    696

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f195be2...1f83714. Read the comment docs.

ThierryO commented 4 years ago

Thanks for the notification. The fix still needs an absolute URL since the README is also displayed at other locations where the relative URL won't work. Can you update the PR?

peterdesmet commented 4 years ago

Well, for the location you mention it seems the relative link also works though: https://cran.rstudio.com/web/packages/bioRad/readme/README.html

I've basically taken the approach from pkgdown itself: https://github.com/r-lib/pkgdown/blob/d01672efa3baa80fd7ab238b7143080b0daf49a4/README.Rmd#L15