Open retowyss opened 4 months ago
https://github.com/ropensci/googleLanguageR/pull/87
Tested this through
text2speech::tts_google(
text = "This works now, yay!",
voice = "en-GB-Neural2-F",
languageCode = "en-gb",
forceLanguageCode = TRUE
)
Thanks, b looks good to prevent breaking changes
For text to speech, the Neural2 voices require passing of the full language code (en-GB, en-US, ...) not just the first two letters (en, ...).
The
gl_talk
implementation forces the languageCode to be derived from the first two letters of thename
parameter, so there's no way to overcome this.I can submit a fix but there are multiple ways this could be resolved.
a) Check whether
name
contains "Neural", if so grab first 5 characters for languageCode b) add parameter to force supplied languageCode parameterforce_languageCode = FALSE
(?)Drawback of a) is it requires code updates to the code for every model that requires the full languageCode.
b) doesn't look elegant, but it will never break existing code. Particularly, it can be passed through
text2speech::tts_google
's...
parameter.I'd prefer the function never overwrites the languageCode, but that surely is a breaking change.