search

ropensci / hunspell

High-Performance Stemmer, Tokenizer, and Spell Checker for R
https://docs.ropensci.org/hunspell
Other
109 stars 44 forks source link

Fix/42 update for RStudio 1.3 #43

Closed GegznaV closed 3 years ago

GegznaV commented 4 years ago

Fixes #42

GegznaV commented 4 years ago

image

This R CMD check failure is not related to this PR, it's related to the wrong setup of Travis CI on Mac (see #44).

jeroen commented 4 years ago

Is there any reason you're randomly replacing quotes? That makes it more difficult to review this.

GegznaV commented 4 years ago

Sorry for the quotes. Instead of fixing indentation in the code I accidentally applied tidyverse style (I pushed a wrong keybòard combination and didn't noticed that) . I'll fix the quotes.

2020 rugs. 8, an 02:32, Jeroen Ooms notifications@github.com rašė:

Is there any reason you're randomly replacing quotes? That makes it more difficult to review this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ropensci/hunspell/pull/43#issuecomment-688540482, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBC43GJMF2UA5GNQKDROTLSEVURXANCNFSM4Q64JAYQ .

GegznaV commented 4 years ago

I undid the style corrections by styler. Now my changes could be seen more clearly.

GegznaV commented 3 years ago

Close in favor of #48