search

ropensci / iheatmapr

Complex, interactive heatmaps in R
https://docs.ropensci.org/iheatmapr
Other
267 stars 36 forks source link

iheatmapr_event not working on relayout #35

Closed oristaszewski closed 5 years ago

oristaszewski commented 5 years ago

this line in iheatmapr_event

else if (event == "iheatmapr_selected") {

should read

else if (event == "iheatmapr_relayout") {

mschilli87 commented 5 years ago

@oristaszewski: You can edit shiny.R on github and automatically create a pull request for that change. Use the little pen in the top-right to do so. Also, to get the proposed change accepted, you should consider adding a short explanation why you think the current code is wrong and how your suggested change fixes this.

oristaszewski commented 5 years ago

thanks for the pointer and done as suggested.

mschilli87 commented 5 years ago

For reference: https://github.com/ropensci/iheatmapr/pull/36

AliciaSchep commented 5 years ago

Thanks @mschilli87 and @oristaszewski, fix is merged into master branch. Thinking of trying to do a few maintenance updates & then another cran release... until then the fix will be on the master branch.