search

ropensci / iheatmapr

Complex, interactive heatmaps in R
https://docs.ropensci.org/iheatmapr
Other
267 stars 35 forks source link

update iheatmapr_event #36

Closed oristaszewski closed 5 years ago

oristaszewski commented 5 years ago

The current implementation references the unsupported selection event but does not offer any code dealing with the supported relayout event - this generates "object 'out' not found" errors. The proposed change allows the function to return the relayout data as expected.

AliciaSchep commented 5 years ago

Thanks for the fix! Happy to add you as a contributor to the package, if you'd like (just would need the name to be included -- would go in https://github.com/ropensci/iheatmapr/blob/master/DESCRIPTION).

AliciaSchep commented 5 years ago

The master branch build has been failing on mac os for a couple weeks, failing check seems to be unrelated to this PR, so will go ahead and merge.