ropensci / iheatmapr

Complex, interactive heatmaps in R
https://docs.ropensci.org/iheatmapr
Other
267 stars 35 forks source link

Fix add_row_annotation to enable removal of colorbar #51

Closed fboehm closed 4 years ago

fboehm commented 4 years ago

I found an error in my earlier pull request. I initially failed to make the revisions needed to signals.R. In this pull request, I've made the changes, and the new code behaves as I had intended.

fboehm commented 4 years ago

Hi, I hope that this isn't an overly naive question. Is it problematic that codecov/patch and codecov/project have "X" next to them in the above checks? I'm just not all that familiar with codecov. I'm happy to make any fixes as needed. Thanks again!

AliciaSchep commented 4 years ago

Sorry I missed this earlier; will merge in now.

fboehm commented 4 years ago

thank you, @AliciaSchep !!