search

ropensci / iheatmapr

Complex, interactive heatmaps in R
https://docs.ropensci.org/iheatmapr
Other
267 stars 35 forks source link

Pump version to update stale binaries #72

Closed ahmohamed closed 4 years ago

ahmohamed commented 4 years ago

The dependency package S4Vectors has updated its methods table, making the methods table here stale. Please refer to the discussion on Bioc-Devel for more details on this issue. (https://stat.ethz.ch/pipermail/bioc-devel/2020-June/016958.html)

I appreciate if this pull request was merged quickly. Cheers. Ahmed.

AliciaSchep commented 4 years ago

Is it correct the package would also need to get re-submitted to CRAN?

ahmohamed commented 4 years ago

Yes. The version pump will trigger binary rebuild on CRAN and Bioconductor, which is the only way to resolve the issue.

AliciaSchep commented 4 years ago

I'm having some issues with the S4Vectors on a fresh installation of this package from source. Not going to push to cran till I figure those out, which probably won't be till a week from now at the earliest. I think it'd probably be best to get rid of that dependency, but that's gonna probably involve a good bit of refactor. Might be necessary though

AliciaSchep commented 4 years ago

@ahmohamed I won't be pushing this version to cran. Will instead be pushing a new version that removes the problematic dependency (once #73 gets merged in and tested further).