ropensci / jagstargets

Reproducible Bayesian data analysis pipelines with targets and JAGS
https://docs.ropensci.org/jagstargets
Other
10 stars 6 forks source link

JOSS Reviewer comments. #27

Closed JonasMoss closed 2 years ago

JonasMoss commented 2 years ago

Hi! Seeing some thorough work here! =)

Here are some minor issues (may update this list in the following days; I'll tell you when I'm done.):

wlandau commented 2 years ago

The package name should now be fixed in the latest commit. To load the vignettes locally, I recommend installing the package with remotes::install_github("ropensci/jagstargets", build_vignettes = TRUE, force = TRUE). build_vignettes is FALSE by default in install_github(), which I think works here because the simulation.Rmd vignette takes a while to render, and the vignettes are rendered at https://docs.ropensci.org/jagstargets/articles/introduction.html and https://docs.ropensci.org/jagstargets/articles/simulation.html and kept up to date with continuous integration.

JonasMoss commented 2 years ago

Aha, thought it was something like that (about the vignettes)! =)