richfitz
commented
8 years ago This looks good to me locally (Linux) and also on the 2 CI platforms. Thanks for referencing the actual jq commits too :rocket:
Closed jeroen closed 8 years ago
richfitz
commented
8 years ago This looks good to me locally (Linux) and also on the 2 CI platforms. Thanks for referencing the actual jq commits too :rocket:
This fixes the "significant warnings" from https://github.com/ropensci/jqr/issues/42. That should make CRAN happy for now.
Fixing jq for solaris or ubsan would require major work and it not worth it if we are going to switch to system libjq soon. But there are many packages with solaris/ubsan issues, so this should be fine for now.