search

ropensci / jqr

R interface to jq
https://docs.ropensci.org/jqr
Other
143 stars 13 forks source link

warning with r-devel #58

Closed sckott closed 6 years ago

sckott commented 6 years ago

@jeroen was about to submit to CRAN - but this warning arises with R-devel on winbuilder and I imagine they'd reject it until fixed

Found the following significant warnings:
  jq/builtin.c:1446:1: warning: string length '14820' is greater than the length '4095' ISO C99 compilers are required to support [-Woverlength-strings]
See 'd:/RCompile/CRANguest/R-devel/jqr.Rcheck/00install.out' for details.

any ideas how to fix?

jeroen commented 6 years ago

Hmm this may not be easy. I've posted it upstream at https://github.com/stedolan/jq/issues/1481

sckott commented 6 years ago

thanks

jeroen commented 6 years ago

I noticed debian finally has jq, so we could choose to unbundle libjq alltogether.

sckott commented 6 years ago

nice, you already have a PR at https://github.com/ropensci/jqr/pull/43 for this

jeroen commented 6 years ago

Right, so we just need to decide if we want to do this. It will make maintenance much easier. But people will need to brew install jq if they want to build from source.

sckott commented 6 years ago

hmmm, the way you set it up, it does give an error message saying to brew install though, yes?

sckott commented 6 years ago

seems good now, closing