search

ropensci / jqr

R interface to jq
https://docs.ropensci.org/jqr
Other
143 stars 13 forks source link

Incorporate streaming #8

Closed richfitz closed 8 years ago

richfitz commented 9 years ago

The bits that we put together in rivr should be useful here.

sckott commented 9 years ago

@richfitz you added jq_iterator() and tests - more to add? or should we close

sckott commented 8 years ago

@richfitz hmm, you added this to the CRAN release milestone. I thought we were dropping rivr things for now, and bringing back later possibly? I made man file for jq_iterator internal only. Perhaps should move the file out of R/ as well so we don't get cran check notes on the call to rivr

richfitz commented 8 years ago

Good point! We should decide on if we're tackling streaming at all though (e.g. with jsonlite's streaming functions).

sckott commented 8 years ago

I was thinking of streaming in jq dev version https://stedolan.github.io/jq/manual/#Streaming which isn't in 1.4 - which would make sense to include, right? But yeah, jsonlite streaming probably means dropping what we were doing with rivr I think

richfitz commented 8 years ago

Ah, crap. That's a bummer. I think that getting 1.5 to work on windows will be nontrivial, but I can have another look some time. Though if we come up with a good interface then it won't matter that much.

At the same time, I don't think that streaming is on most people's radar so I'm not sure people will see it as a killer feature.