search

ropensci / jsonld

R wrapper for jsonld.js JavaScript library
https://docs.ropensci.org/jsonld
Other
35 stars 0 forks source link

upgrade to 1.1? #17

Open cboettig opened 4 years ago

cboettig commented 4 years ago

Hi @jeroen , what's the upstream source location for https://github.com/ropensci/jsonld/tree/master/inst/js ? Also, looks like it is at version 1.0.1. I think the W3C release version is 1.1 now. (For context, I'm trying to duplicate the behavior Gregg documents here: https://github.com/w3c/json-ld-framing/issues/58#issuecomment-518872021 when applying a frame).

jeroen commented 4 years ago

https://github.com/ropensci/jsonld/pull/18

cboettig commented 4 years ago

@jeroen Thanks, but from what I can tell this does not seem to have the fix documented at https://github.com/w3c/json-ld-framing/issues/58#issuecomment-518872021 ... I guess I will need to follow up with them...

davidlehn commented 4 years ago

@cboettig There are many tests that are skipped at the moment since they have not yet been addressed in the code. Some of the tests relevant here show up in the test runner, but that leading '-' in the output is just noting they are skipped. If you want to see the result of the test failure, the skip patterns can be adjusted here: https://github.com/digitalbazaar/jsonld.js/blob/master/tests/test-common.js.

cboettig commented 4 years ago

aha! Excellent. I should have spotted the - instead of the check in https://travis-ci.org/digitalbazaar/jsonld.js/jobs/585843847#L1412. At least I know what I'm looking for now!