search

ropensci / jstor

Import journal data from DfR (JSTOR)
https://docs.ropensci.org/jstor
47 stars 9 forks source link

Fix for readr 1.2.0 #75

Closed jimhester closed 5 years ago

jimhester commented 5 years ago

readr 1.2.0 no longer guesses columns are of type integer, instead these columns are guessed as numeric. See https://github.com/tidyverse/readr/blob/master/NEWS.md#integer-column-guessing for details.

There was a test which broke due to this change, and was fixed by specifying explicitly the type of id to be integer.

Sorry for the breakage!

I plan to submit readr 1.2.0 soon, so you will need to submit jstor after it is accepted to prevent test failures on CRAN.

tklebel commented 5 years ago

Thanks for the notification and the fix! Hope submission goes smoothly this time! :)