search

ropensci / mapscanner

R package to print maps, draw on them, and scan them back in
https://docs.ropensci.org/mapscanner/
Other
90 stars 7 forks source link

CRAN warning from concaveman.h #50

Closed mpadge closed 4 months ago

mpadge commented 4 months ago

Copy of UrbanAnalyst/dodgr#235

This line:

https://github.com/UrbanAnalyst/dodgr/blob/e56ccf2a6a4f67e5c0df5d3baaaa4b69f4fd8a45/src/concaveman.h#L418

generates a warning on Fedora g++ that:

concaveman.h:418:48: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor] See the install log for details. used C++ compiler: ‘g++-14 (GCC) 14.1.0’

The lines from install log are then:

g++-14 -std=gnu++17 -I"/data/gannet/ripley/R/R-devel/include" -DNDEBUG -I. -I'/data/gannet/ripley/R/test-dev/Rcpp/include' -I'/data/gannet/ripley/R/test-dev/RcppParallel/include' -I'/data/gannet/ripley/R/test-dev/RcppThread/include' -I/usr/local/include    -fpic  -g -O2 -Wall -pedantic -mtune=native -Wno-ignored-attributes -Wno-parentheses -Wp,-D_FORTIFY_SOURCE=3 -fexceptions -fstack-protector-strong -fstack-clash-protection -fcf-protection   -c concaveman.cpp -o concaveman.o
In file included from concaveman.cpp:1:
concaveman.h:418:48: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
  418 |     template<class... Args> CircularElement<T>(Args&&... args):
      |                                                ^~~~
concaveman.h:418:48: note: remove the '< >'