search

ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

Add Windows continuous integration #113

Closed karthik closed 10 years ago

karthik commented 10 years ago

Hi @SimonGoring, We're doing a org wide deployment of Windows builds thanks to @sckott. Today he noticed that we missed Neotoma. Mind if we add it?

SimonGoring commented 10 years ago

No, no problem. Does this mean they'll go up to cran?

On Thu, Aug 21, 2014 at 12:43 PM, Karthik Ram notifications@github.com wrote:

Hi @SimonGoring https://github.com/SimonGoring, We're doing a org wide deployment of Windows builds thanks to @sckott https://github.com/sckott. Today he noticed that we missed Neotoma. Mind if we add it?

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/issues/113.

karthik commented 10 years ago

No it doesn't go up on CRAN. It does the same thing that Travis does for Linux but for Windows. In other words, with every push it will run tests to make sure your package will still install on a Windows machine.

gavinsimpson commented 10 years ago

There are a lot of things we need to fix before we can get neotoma on CRAN. When I ran R CMD check recently on a locally built tarball there were quite a number of warnings and notes which wouldn't allow the package on to CRAN without some attention.

sckott commented 10 years ago

@gavinsimpson right, all seem pretty easy to fix

gavinsimpson commented 10 years ago

@sckott Yep, and some of this will need neotoma to settle down a bit - @SimonGoring has been making lots of improvements lately such as the classed objects now returned by some functions, changes to the naming of functions. No point prematurely documenting things if further changes are in the offing?

The only issue that seemed odd was something to do with the namespace and masking IIRC, which I hadn't started to look into yet.

karthik commented 10 years ago

@SimonGoring Just give us to go ahead once you're done with the major overhaul.

gavinsimpson commented 10 years ago

Found the source of the significant NAMESPACE warning during R CMD check. Will push some changes to my clone and then get a PR going.