ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

Add testthat and knitr packages as Suggests #115

Closed sckott closed 10 years ago

sckott commented 10 years ago

Hey @SimonGoring

I think a few pkgs (testthat and knitr) need to be added to the DESCRIPTION file like https://github.com/ropensci/taxize/blob/master/DESCRIPTION#L48

lack of testthat is probably why recent Windows build failed, and should be in there anyway

and knitr because i think you use markdown vignette

gavinsimpson commented 10 years ago

Oops, in referencing this Issue I didn't realise it wasn't a PR. I've got a local change implementing this suggestion so I'll do a PR on it in a minute or two.

sckott commented 10 years ago

cool, sounds good @gavinsimpson

SimonGoring commented 10 years ago

I assume this is closed now. I guess we forgot to do it? @sckott @gavinsimpson

sckott commented 10 years ago

looks like it's done now :+1: