search

ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

Windows builds failing because of the `.Rproj` file #129

Closed gavinsimpson closed 10 years ago

gavinsimpson commented 10 years ago

The Appveyor Windows builds are failing because the *.*proj extension is used to identify a Visual Studio project which the MSBuild script wants to do something with. As the repo has a *.Rproj this seems to be being recognised by the build script as a *.*proj file in the Visual Studio sense. You can see the error message here: https://ci.appveyor.com/project/sckott/neotoma/build/1.0.21#L5

Does anyone know if we can hide this file from Appveyor, or should we just add this to the .gitignore list and remove it from the repo?

Thoughts @karthik @sckott ? How have you handled this for other ropensci repos?

sckott commented 10 years ago

@gavinsimpson I haven't seen that error before. I'll look around and see if there's a way to have the windows server ignore certain files

SimonGoring commented 10 years ago

There's no reason to be synching the Rproj file from branch to branch. We can get rid of it, or .gitignore it.

sckott commented 10 years ago

@krlmlr is there a way to ignore certain files / files matching certain pattern on Appveyor? See above problem with Rstudio's project files

gavinsimpson commented 10 years ago

@SimonGoring if you use RStudio then having this file would be handy for you but it doesn't need to be under VC. To remove it now, we'd need to make a copy of it, git rm it, then add it to .gitignore, then have you/anyone needing to use it bring the copy back.

I didn't want to kill it if you used RStudio and liked having the .Rproj file.

SimonGoring commented 10 years ago

Okay. I just did that for another file yesterday. I'll take care of it soon, but maybe not until Monday.

On Fri, Aug 22, 2014 at 1:55 PM, Gavin Simpson notifications@github.com wrote:

@SimonGoring https://github.com/SimonGoring if you use RStudio then having this file would be handy for you but it doesn't need to be under VC. To remove it now, we'd need to make a copy of it, git rm it, then add it to .gitignore, then have you/anyone needing to use it bring the copy back.

I didn't want to kill it if you used RStudio and liked having the .Rproj file.

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/issues/129#issuecomment-53105762.

krlmlr commented 10 years ago

Really, this should be handled gracefully by AppVeyor. @FeodorFitsner: Any thoughts?

FeodorFitsner commented 10 years ago

Just point it to the right direction by specifying solution/project to build:

build:
  project: YourSolution.sln
krlmlr commented 10 years ago

Thanks. What do I have to specify to completely avoid msbuild? We already have build_script in the .yml.

FeodorFitsner commented 10 years ago

Nothing, if you have build_script section. It's either build or build_script.

krlmlr commented 10 years ago

Thanks for the confirmation. I was misled, thinking that the project with the failing build was already an .yml project. Turns out that adding the .yml seems to have resolved the issue.

sckott commented 10 years ago

Thanks @krlmlr and @FeodorFitsner for helping out here!

SimonGoring commented 10 years ago

Yes, thanks all!

On Fri, Aug 22, 2014 at 7:22 PM, Scott Chamberlain <notifications@github.com

wrote:

Thanks @krlmlr https://github.com/krlmlr and @FeodorFitsner https://github.com/FeodorFitsner for helping out here!

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/issues/129#issuecomment-53136873.

gavinsimpson commented 10 years ago

Thanks; I appreciate everyone looking into this for us.