search

ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

remove plyr functions from get_dataset #136

Closed gavinsimpson closed 10 years ago

gavinsimpson commented 10 years ago

In looking at #132 there is no reason to use plyr here at all as lapply will work nicely too and should be as quick if not quicker. Additional changes involve removing the use of return() and replacing the anonymous function in the dataset method of get_dataset.

gavinsimpson commented 10 years ago

Ping... @SimonGoring Thoughts on this?

SimonGoring commented 10 years ago

I'm fine with this. I agree, if we can get rid of plyr functions then we ought to. The less dependencies the better. I was working on it, sent you an offline email about working to resolve it.

On Thu, Sep 18, 2014 at 10:37 AM, Gavin Simpson notifications@github.com wrote:

Ping... @SimonGoring https://github.com/SimonGoring Thoughts on this?

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/pull/136#issuecomment-56057071.

gavinsimpson commented 10 years ago

Thanks @SimonGoring (Just figured this got overlooked) When did you send the email? I've been travelling and off work recently so I may not have seen it but nothing is showing in GMail at the moment.

SimonGoring commented 10 years ago

Yep, I didn't even realize it was a pull request when you pinged me!

On Thu, Sep 18, 2014 at 10:48 AM, Gavin Simpson notifications@github.com wrote:

Thanks @SimonGoring https://github.com/SimonGoring (Just figured this got overlooked) When did you send the email? I've been travelling and off work recently so I may not have seen it but nothing is showing in GMail at the moment.

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/pull/136#issuecomment-56058878.