search

ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

Finding consistency between classes. #143

Closed SimonGoring closed 10 years ago

SimonGoring commented 10 years ago

This standardizes most function variable and list names to lower.case format. Fixes minor bugs and creates *_list classes for datasets as well as downloads. Bugs remain.

gavinsimpson commented 10 years ago

@SimonGoring Where are we standardising the arguments of methods for individual generics? You don't appear to have fixed that issue in the set of PRs this evening. Do you want me to tackle that issue?

SimonGoring commented 10 years ago

Are you talking about making sure that I'm always using x in each of get_download.site and get_download.dataset? I haven't done that yet. My standardization was making sure that the dataset looks like a dataset a dataset object and in the dataset component of a download. It wasn't like that before.

Right now I'm fixing the conflicts between my commits and the doc_fix branch that @karthik pushed.

On Thu, Sep 25, 2014 at 9:21 PM, Gavin Simpson notifications@github.com wrote:

@SimonGoring https://github.com/SimonGoring Where are we standardising the arguments of methods for individual generics? You don't appear to have fixed that issue in the set of PRs this evening. Do you want me to tackle that issue?

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/pull/143#issuecomment-56912006.

gavinsimpson commented 10 years ago

@SimonGoring I think PR #145 handles the problem with download.R

gavinsimpson commented 10 years ago

@SimonGoring Re the argument names for generics and methods. Yes, that's right. Feel free to delegate this - you don't have to shoulder all the burden of coding :) - I'm happy to work on that particular issue.